search

m0ngr31 / kodi-voice

Python library for interacting with Kodi (especially with Voice)
MIT License
19 stars 23 forks source link

Make inclusion of song-only artists configurable #5

Closed jingai closed 7 years ago

jingai commented 7 years ago

Recently added the paramater "albumartistsonly": False to AudioLibrary.GetArtists, which tells Kodi to include artists that only appear on individual songs. In most cases, I think this is the right thing to do, but some users are experiencing timeouts due to the additional size of the response.

It could be worth simply making it a configurable option.

jingai commented 7 years ago

Looking into this further to see if it's really an issue. Having trouble seeing how adding a few extra artists to the response has made such a noticeable difference for him. Hang tight.

jingai commented 7 years ago

This user in particular has ~3000 song-only artists, which probably does make a difference. But, if he were to disable the feature, most of his music queries probably wouldn't work at all.

I'm inclined to say it's a non-issue.