search

m0ppers / syncthing-bar

A statusbar for syncthing on Mac OS X
Other
134 stars 16 forks source link

Tray icon should become white when the menu drops down #13

Closed jamesgecko closed 9 years ago

jamesgecko commented 9 years ago

Minor detail, but possibly worth fixing.

This is what f.lux (and all the default OS X tray icons) do. screenshot 2015-05-13 18 19 07

Here is what syncthing-bar does. screenshot 2015-05-13 18 19 18

Syncthing's icon does change when selected, but it gets darker not lighter. Also, the entire icon is changed, even the transparent part.

In dark menubar mode, it is appropriate to not change the icon when selected. Again, the default menu bar widgets behave the same way. screenshot 2015-05-13 18 23 37

chrisidefix commented 9 years ago

If somebody is looking into this, I would like to add that the menu-bar icon on a secondary screen behaves a little strange: The icon becomes fully white on whichever monitor is currently in-active.

inactive

Under Mavericks a monitor that currently does not have the focus renders the menu-bar more transparent. When this happens the syncthing-bar icon changes completely. I wonder if this is a transparency issue with the icon or if some property is not defined in the Xcode project?

If anyone could point me into the right direction, I would like to help fix this.

chrisidefix commented 9 years ago

I figures that this was simply a transparency issue in the icon used. I added a new icon just for the menu bar, which fixes these problems: pull request: #14

chrisidefix commented 9 years ago

PS: if you prefer the inverted version of the icon - I also have that available...

m0ppers commented 9 years ago

Thanks for the new icon @chrisidefix. New release has been published :D closing :D

jamesgecko commented 9 years ago

Pure awesome. Thanks y'all!