m0r13 / mclogalyzer

Minecraft Server Log Analyzer
GNU General Public License v3.0
44 stars 20 forks source link

Fixed RegEx for logout in 14w18b, first_login and last_login, using whitelist #1

Closed PofMagicfingers closed 10 years ago

PofMagicfingers commented 10 years ago

Hi !

It's a big pull request, but here is my additions to your wonderful tool.

Big new feature :

Please note that I'm not used to python, I think that's the second time I use this language, feel free to correct me on anything.

Thanks, Pof.

m0r13 commented 10 years ago

Hey,

Sorry, I forgot that pull request a bit. I will have a look at it.

m0r13 commented 10 years ago

Your changes look fine, I only think that a JSON file is a bit of an overkill as whitelist file. I think a simple text file with one username per line would be enough. Also you didn't specify the format this JSON file should have.

I'll merge your changes and change the whitelist.json to a whitelist.txt. Also adding a blacklist could be a neat feature too I think.

m0r13 commented 10 years ago

Oh wait I'm a derp, I didn't realize there is a new whitelist format. :)