search

m0r13 / mclogalyzer

Minecraft Server Log Analyzer
GNU General Public License v3.0
44 stars 20 forks source link

PEP8 Update and Support Achievements #10

Closed johnwoltman closed 9 years ago

johnwoltman commented 9 years ago

I used my text editor to fix the PEP8 "tabs instead of spaces" recommendation. I added support for achievement counting and listing the achievements.

m0r13 commented 9 years ago

Hey, sorry I'm a bit busy at the moment, but I'll have a look at it later.

Another little problem for me is also that I don't have an active Minecraft server anymore. Thus also no up-to-date log files to continue the development of this tool.

johnwoltman commented 9 years ago

Since there's no sensitive info that I care about, maybe I can provide a set of logs for testing. Is there a good website to throw up a bunch gzipped text files? I could add them to mclogalyzer's repo if that's better.

m0r13 commented 9 years ago

Providing some log files would be cool. Maybe you would want to replace the ip addresses and/or user names with some random stuff. I think directly adding them to the repo would be okay if they aren't too large.

Gjum commented 9 years ago

You could also upload them as Gist instead of gzipping them.

m0r13 commented 9 years ago

I think it would be better to add them to the repo or upload them somewhere else in an archive, since the log files are already in a specific structure (gzipped log files for every day) which is also needed by mclogalyzer.

m0r13 commented 9 years ago

Also, I had a short look at your changes and it looks fine. I'll merge it.

johnwoltman commented 9 years ago

I will try anonymizing some of my server logs and add them in a future PR.