search

m0spf / cloudlog-docker

Fully automated dockerised Cloudlog (https://github.com/magicbug/Cloudlog)
8 stars 3 forks source link

[Feature request] Do the cert generation optional #3

Closed dgdavid closed 3 years ago

dgdavid commented 3 years ago

@tx44

Thanks a lot for your amazing work here. It works pretty good!

Just wondering if I can suggest making the certification generation optional, via variable in .env file, by asking to the user in the install script or whatever other way you considered better.

Thanks!

m0spf commented 3 years ago

Hi @dgdavid glad it is working ok for you. I have been meaning to come back to this project to make some improvements and have just added a few issues that need sorting.

My intention for SSL was that if the instance is public facing then letsencrypt automatically takes care of cert issue/renewal, however if the instance is private then a self signed cert is generated. I dont suppose it would be any harm having an option to disable SSL entirely, however this isnt really best practice even if the instance is local.

Is there a particular reason you want to disable certs, did you have issues with the automation generation?

dgdavid commented 3 years ago

Sorry, I don't know too much about SSL/certs generation. Just thinking in services that already cares about it. Maybe incompatible with this kind of automation?

Thanks a lot for the explanation. Much appreciated.

dgdavid commented 3 years ago

Just thinking in services that already cares about it.

And to avoid the browser warning in a development mode (see #5)

dgdavid commented 3 years ago

As said in https://github.com/m0spf/cloudlog-docker/issues/5#issuecomment-910256269

Closing it because I quit using Cloudlog. For sure, anyone else interested on it can reopen the issue.