search

m0spf / cloudlog-docker

Fully automated dockerised Cloudlog (https://github.com/magicbug/Cloudlog)
8 stars 3 forks source link

[Question] Why doing replacements one by one #4

Closed dgdavid closed 2 years ago

dgdavid commented 3 years ago

Just out of curiosity, I would like to know why you are running a new container for each replacement in the config files

https://github.com/tx44/cloudlog-docker/blob/e2ea95fc371320c9b0dbf4ee5d17a33e7f5f29e4/install.sh#L66-L88

instead of performing all of them in the same container.

Also wondering why you did not extract that logic to another script called during the install one.

Thanks a lot in advance.

m0spf commented 3 years ago

Sorry for the delayed reply, you are right, most of these commands could be executed in a single container, i'll add this to my list, or feel free to submit a PR.

dgdavid commented 3 years ago

or feel free to submit a PR.

I thought to do it, but finally I stop using Cloudlog. I really sorry not being not much helping here.