Feature Req: Swap default value of 'sflow' directive

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Run an sflow-enabled nginx without an existing, valid /etc/hsflowd.auto
2. Lots of noise to error logs

What is the expected output? What do you see instead?
Less noise :)

What version of the product are you using? On what operating system?
0.9.4 with nginx 1.1.0 and 1.1.1

Please provide any additional information below.
I run a lot of different types of servers with the same nginx build. It's 
really easy to generate a mountain of log entries to nginx error log on boxes 
that don't expect to be running sflow and /etc/hsflowd.auto doesn't exist (and 
if it does exist but is empty, I get piles of errors like "syntax error : 
agentIP=<IP address>|<IPv6 address> (on line 0) while logging request...").

I think it would be less surprising to default to 'sflow off;' and have it 
activated with 'sflow on;', rather than defaulting to on. Or alternatively, if 
/etc/hsflowd.auto exists but is empty, then disable sflow logging.

Love the module btw!

Original issue reported on code.google.com by moseleym...@gmail.com on 31 Aug 2011 at 9:02

[GoogleCodeExporter]

Agreed. Empty or missing .auto file should just turn sFlow off with no logging.

Original comment by neil.mck...@gmail.com on 1 Sep 2011 at 10:09

• Changed state: Accepted

[GoogleCodeExporter]

Version 0.9.5 reduces logging when config is missing or empty.  Please confirm.

Please note,  that in 0.9.5 the output format has changed (the sFlow-HTTP spec 
was finalized so now this module conforms to that spec -- see sflow.org).

Collector options:

The latest sflowtool sources (sflowtool version 3.23 or later)
The (commercial product) InMon Traffic Sentinel (6.0 or later) 
The Ganglia trunk (ganglia.sourceforge.net) now accepts the sFlow-HTTP counters.

Neil

Original comment by neil.mck...@gmail.com on 10 Jan 2012 at 9:33

• Changed state: Fixed