search

m1212e / prismabox

typebox schema generator for prisma
MIT License
38 stars 7 forks source link

Add inputSelect inputOrderBy and inputInclude #19

Closed fortezhuo closed 2 months ago

fortezhuo commented 2 months ago

I just make simple patch, refactoring relations.ts, and bump dependencies. Please review

m1212e commented 2 months ago

Hi, thank you very much for your input! I'll take time to review this throughout the next week or so. Do you have some deadline/is this urgent for you?

fortezhuo commented 2 months ago

I think I still can run and build generated files on my local computers and copy them manually.

So no worries, I can wait. Please take your time to review 🙏

m1212e commented 2 months ago

Hey, I took a first look and I'd like to rework a few things to make it comply to the current project structure. I'll do this throughout the next days and merge as soon as it's ready! Thanks for your contribution!

fortezhuo commented 2 months ago

Thanks. but I found the whereSchema also need to be tweaked. If we need to use combination operator like contains, gt, lt, etc the current where schema still not supported. I still dev this feature, and tested it.. if it's ready, I will make another PR. https://www.prisma.io/docs/orm/prisma-client/queries/filtering-and-sorting

m1212e commented 2 months ago

I've implemented simplified models to validate the other query options you requested in the latest release. I took some inspiration from you PR but ultimately decided to implemet it on the main. Feel free to take a look and close/fork if you want to!

fortezhuo commented 2 months ago

I have take a look. And I think I can close this PR. Thanks for implementing it. And since whereSchema needs to be tweaked using operator, I will fork and custom it and republish for meet our dev needs

m1212e commented 2 months ago

Thank you very much for your input!