Closed persmule closed 7 years ago
After adding the positional argument, the problem get fixed. The value of the parameter could even be 'Bilibili' to avoid unnecessary auto detection, since bilidan is designed for Bilibili.
I agree. Please change that to 'Bilibili' and I will merge your change.
Thanks.
That has been changed to 'Bilibili', and no new issue appears.
After the argument 'input_format' was added to Danmaku2ASS. the function call in bilidan became incompatible and get error log "ERROR: Danmaku2ASS() missing 1 required positional argument: 'input_format' ERROR: Danmaku2ASS failed, comments are disabled." when running. After adding the positional argument, the problem get fixed. The value of the parameter could even be 'Bilibili' to avoid unnecessary auto detection, since bilidan is designed for Bilibili.