search

m13253 / BiliDan

Play videos on Bilibili.com with MPV and Danmaku2ASS
http://m13253.blogspot.com/2014/06/watch-bilibili-with-biligrab-danmaku2ass.html
Other
513 stars 69 forks source link

fix function call incompatibility on Danmaku2ASS, due to API change. #78

Closed persmule closed 7 years ago

persmule commented 7 years ago

After the argument 'input_format' was added to Danmaku2ASS. the function call in bilidan became incompatible and get error log "ERROR: Danmaku2ASS() missing 1 required positional argument: 'input_format' ERROR: Danmaku2ASS failed, comments are disabled." when running. After adding the positional argument, the problem get fixed. The value of the parameter could even be 'Bilibili' to avoid unnecessary auto detection, since bilidan is designed for Bilibili.

m13253 commented 7 years ago

After adding the positional argument, the problem get fixed. The value of the parameter could even be 'Bilibili' to avoid unnecessary auto detection, since bilidan is designed for Bilibili.

I agree. Please change that to 'Bilibili' and I will merge your change.

Thanks.

persmule commented 7 years ago

That has been changed to 'Bilibili', and no new issue appears.