search

m13253 / dns-over-https

High performance DNS over HTTPS client & server
https://developers.google.com/speed/public-dns/docs/dns-over-https
MIT License
1.96k stars 221 forks source link

Add GitHub actions to build master and each PR #108

Closed gdm85 closed 3 years ago

gdm85 commented 3 years ago

Add GitHub actions to build master and each PR.

I did not see a Makefile target to build for Windows, so I did not add the stanzas for that.

There are also no integration tests otherwise they could be added as well.

This PR additionally moves from Go 1.12 to Go 1.13 because of the modules support, which allows to not have a deps target anymore, since Go does that automatically. Build was failing without upgrading to Go 1.13

m13253 commented 3 years ago

This is cool! We now don't need to do deps manually. But do you know whether it still works when I concurrently build doh-server and doh-client at the same time by issuing make -j999 if I remove deps?

gdm85 commented 3 years ago

But do you know whether it still works when I concurrently build doh-server and doh-client at the same time by issuing make -j999 if I remove deps?

Go handles that gracefully, it locks the file objects it uses from within the Go build cache.