m13253 / dns-over-https

High performance DNS over HTTPS client & server
https://developers.google.com/speed/public-dns/docs/dns-over-https
MIT License
1.97k stars 221 forks source link

Support for URI Template #18

Open m13253 opened 6 years ago

m13253 commented 6 years ago

IETF DoH requires a URI Template while configuring the client.

For example: /query{?dns}

This implementation does not support URI Template yet, and still uses the obsolete ct= parameter to negotiate protocols. We need to eventually switch to URI Template in the future.

But since it does not affect compatibility (either client or server side), and I do not have a clear understanding of it until the next extension of the protocol is published, I plan to leave this issue open and postpone this.

And as always, pull request is welcome.

m13253 commented 5 years ago

I plan to solve this problem when IETF proposes any new standards in extension to RFC 8484. At that time it will be clear how we can solve the problem.

Prior to that, it is worth mentioning that we still need to maintain compatibility to Google DoH for the following reason:

Please discuss if anyone can come up with an idea to maintain compatibility and adapt URI Template.

gdm85 commented 2 years ago

Has this changed in the last ~2 years?

m13253 commented 2 years ago

It seems that no DoH server really relies on the URI template feature, although it is specified in the RFC. I think it may not be worth it to implement it — because implementing it requires refactoring some old code.

I would rather leave current code as is.

m13253 commented 2 years ago

So this is still an issue, patches are welcome.

But it currently bothers nobody even kept unfixed, and unfortunately my life is getting busy and can't afford allocating efforts to fix this issue.

I prefer to keep it unfixed.