m13ammed / Semantic-Segmentation-using-Implicit-Representation

2 stars 1 forks source link

Bugs #2

Closed kghandour closed 1 year ago

kghandour commented 1 year ago
m13ammed commented 1 year ago

datadir is datadir of plenoxel while scannet_dir is data dir of scannet data therefore not duplicate when working with scannet data give the path to the scannet_data and you would not need to add the plenoxels prefix

m13ammed commented 1 year ago

I wrote it this way to be able to load even when scannet and plenoxel datasets are not in the same folders

m13ammed commented 1 year ago

you should not need to add plenoxels prefix to the ply if you pass the scannet dir to the scannet_dir argument rather than datadir

m13ammed commented 1 year ago

double check on my comment if it still raises an issue inform me to adjust accordingly

kghandour commented 1 year ago

datadir is datadir of plenoxel while scannet_dir is data dir of scannet data therefore not duplicate when working with scannet data give the path to the scannet_data and you would not need to add the plenoxels prefix

You misunderstood. I mean that we should write the path for the datasets (one for perfception "datadir" and one for scannet "scannet_dir") in ONE ginc file and then for all the other config files that uses these variables they can just inherit it from one parent ginc file. I do support having two variables one for perfception and one for scannet as is now, I just don't want to change the path in every single ginc that is all

m13ammed commented 1 year ago

okay i understand your point now. thank you for the clarification. will look into this as well, makes since to only change the dirs once rather than for two ginc files