m19c / gulp-run

Pipe to shell commands in gulp
ISC License
151 stars 25 forks source link

Fix node_modules/.bin not being included to PATH. #13

Closed koresar closed 10 years ago

koresar commented 10 years ago

Since the main code moved from . to ./lib the PATH env variable contained the following: /MY/PROJECT/DIRECTORY/node_modules/node_modules/.bin.

koresar commented 10 years ago

Although, I don't know how to unit test test this code.

koresar commented 10 years ago

Thanks for the merge! When do you think this will get to npmjs.org?

cbarrick commented 10 years ago

Thanks! Sorry I missed that.

I'm tweaking the fix slightly by removing the extra node_modules instead of adding another ... That seems a little more sensible than going up above node_modules only to descend back into the same directory. I'm not sure why I didn't do that in the first place :P.

I'll publish a new version to npmjs.org asap.

cbarrick commented 10 years ago

A new version (v1.6.3) should be available from npm now.

koresar commented 10 years ago

Don't forget to pusg package.json with v1.6.3. :)

cbarrick commented 10 years ago

lol, thanks. It's been pushed and tagged: 52cd14bcab78d94912eb73a484dd78379f06308b / v1.6.3