search

m1dugh / native-sound-mixer

MIT License
25 stars 13 forks source link

Feat: `pkg-prebuilds` #23

Closed hrueger closed 1 year ago

hrueger commented 1 year ago

Hi @m1dugh, are you interested in me making a PR to add @Julusian's excellent pkg-prebuilds tooling?

This would add a GitHub Action which would build the prebuild binaries on Windows and Linux for amd64 (maybe also amd64). Then, you could ship those directly in the pakage published on npm. This has the benefit of not requiring users to have a working node-gyp build environment as well as easy cross-compilation (as in fact no compilation should be needed when installing the lib).

Let me know what you think.

m1dugh commented 1 year ago

If you can make it work properly, it could be nice indeed. I'll look further into github actions as soon as I can.

hrueger commented 1 year ago

Sure, I'll make a PR in the next couple days 👍

m1dugh commented 1 year ago

I've started adding CI with github actions in branch 27-add-basic-cicd-for-push-event using cmake-js to replace node-gyp

hrueger commented 1 year ago

Cool. How would you like me to proceed here? Should I add the pkg-prebuilds to a new PR based on that branch or rather wait until you merge #28? The latter is probably less complicated.

m1dugh commented 1 year ago

I will merge the ci PR soon so it might be easier to wait.

m1dugh commented 1 year ago

I merged the CI to develop, alongwith the cmake-js build replacing node-gyp

hrueger commented 1 year ago

Thanks, I'll try to make a PR tomorrow 👍

hrueger commented 1 year ago

I'm sorry I didn't find time today and will probably not have some over the holidays. In case you want to implement that, maybe this pr helps. However, I can also do it in January.