search

m1entus / MZFormSheetPresentationController

MZFormSheetPresentationController provides an alternative to the native iOS UIModalPresentationFormSheet, adding support for iPhone and additional opportunities to setup UIPresentationController size and feel form sheet.
MIT License
973 stars 146 forks source link

Change Transition Style enum to not conflict with MZFormSheetController #5

Closed ay8s closed 9 years ago

ay8s commented 9 years ago

I'm using MZFormSheetController in our iOS 7/8 app, I use it as a dependency within a couple of private Cocoapods. I use the MZFormSheetPresentationController for iOS 8 and MZFormSheetController for iOS 7.

Now MZFormSheetPresentationController is separated out pushing a Cocoapod Spec with both MZFormSheetController & MZFormSheetPresentationController it returns a "redefinition of enumerator" error.

This should resolve things I think, there might be a better solution.

ay8s commented 9 years ago

Looks like there are a bunch of other duplicate symbols. Wonder if theres a better method to get around this?

m1entus commented 9 years ago

Thanks forgot about this enum during refactor

ay8s commented 9 years ago

I've just updated a bunch of other things, not sure if they are needed. Can pull request those as well if you check my fork.

Apologies about the naming, not sure if adding "Presentation" makes sense.

m1entus commented 9 years ago

Sure go ahead, i will check it in free time and i am sure we will be to update this project. Actually i shouldn't name this project including name "PresentationController" because it doesn't inherit from UIPresentationController, but it is already done so it is good if we will be using this prefix ;)