search

m1ga / ti.zendesk

MIT License
1 stars 3 forks source link

Android: Using deprecated Android API? #1

Open hansemannn opened 2 years ago

hansemannn commented 2 years ago

During the iOS development, I noticed some parity issues in the initialization of the module. iOS needs an app ID, client ID and url, while Android uses an API key. Looking at the Android docs, Android requires the same as iOS there, which leads me to think that the Android implementation may use an outdated API? I can easily migrate to the newer one while I am at it, just let me know!

m1ga commented 2 years ago

Interesting. I was using those docs: https://developer.zendesk.com/documentation/zendesk-web-widget-sdks/sdks/android/getting_started/ which uses zendesk.messaging only, I'm not using the whole support library. So it is a different part of the API. iOS messaging needs a key too: https://developer.zendesk.com/documentation/zendesk-web-widget-sdks/sdks/ios/getting_started/

But we can implement both parts

m1ga commented 2 years ago

Looks like the SDK I'm using is newer:

The Zendesk Web Widget and SDKs are relatively new, and as such, do not have all of the features and customization options of our previous Classic SDKs. Depending on your needs and the interactions that you'd like to provide to your customers, you may be interested in exploring them as well. You can check out our documentation to learn more about the Classic SDKs

but we can't use both:

Note: The Zendesk mobile SDK for Messaging is not compatible with the Classic mobile SDKs. Using both within the same app is not supported and may produce unexpected results.

So if we want to support more features I should switch to the old SDK you are using

hansemannn commented 2 years ago

Okay, weird architecture decision from Zendesk. Then just keep it as-is for now and orientate based on the needs of the community later?

m1ga commented 2 years ago

If both display the same Messaging view it should be fine for now :+1:

I'll try to get a demo account and check both implementations. Could you add a binary file in the PR then I can review it at the weekend and merge the stuff.

Thanks!

I'll keep this one open and check everything at the weekend