search

m1guelpf / yt-whisper

Using OpenAI's Whisper to automatically generate YouTube subtitles
MIT License
1.36k stars 138 forks source link

Replaced youtube_dl with yt-dlp #18

Closed amitalokbera closed 1 year ago

amitalokbera commented 2 years ago

Closes #17

Replaced youtube_dl with yt-dlp to download videos much faster and also made relevant changes in README.md

m1guelpf commented 2 years ago

Can you install it via pip instead? Would like to not add extra friction

amitalokbera commented 2 years ago

done

BaseInfinity commented 1 year ago

I had to remove the reference to youtube_dl_log to get this working on line 7 in /Users/meow/Library/Python/3.9/lib/python/site-packages/yt_whisper/cli.py :

Traceback (most recent call last):
  File "/Users/meow/Library/Python/3.9/bin/yt_whisper", line 5, in <module>
    from yt_whisper.cli import main
  File "/Users/meow/Library/Python/3.9/lib/python/site-packages/yt_whisper/cli.py", line 7, in <module>
    from .utils import slugify, str2bool, write_srt, write_vtt, youtube_dl_log
ImportError: cannot import name 'youtube_dl_log' from 'yt_whisper.utils' (/Users/meow/Library/Python/3.9/lib/python/site-packages/yt_whisper/utils.py)
BaseInfinity commented 1 year ago

Thanks for this pull request! The download is sooo much faster

m1guelpf commented 1 year ago

Thank you for this! Makes downloads much much faster ❤️