support for local files as input videos

m1guelpf / yt-whisper

Using OpenAI's Whisper to automatically generate YouTube subtitles

MIT License

1.36k stars 138 forks source link

Open micheleAlberto opened 1 year ago

micheleAlberto commented 1 year ago

fixes #25

BEFORE: the video cli argument must be a youtube url AFTER: the video cli argument must be a youtube url or local file

what-the-diff[bot] commented 1 year ago

Added type annotations to the function parameters
Changed get_audio() so that it can accept local video files as well as URLs
Fixed a bug where audio was not being extracted from videos when using ffmpeg (the command is now run)

sloganking commented 1 year ago

Is this meaningfully different from #28 ?

ahmed024 commented 1 year ago

Yes, there is different this and #28 . With this, you dont get the this error ModuleNotFoundError: No module named 'utils'

micheleAlberto commented 1 year ago

A friend would like to use this. Can we merge it or should I tell him to work from my fork?