search

m1k1o / neko

A self hosted virtual browser that runs in docker and uses WebRTC.
https://neko.m1k1o.net/
Apache License 2.0
7.17k stars 526 forks source link

How to turn on chat sound permanently? #131

Closed reformedp closed 2 years ago

reformedp commented 2 years ago

I am using neko:latest docker image. I would like to have chat sound on whenever a user first connects and reconnects. Currently, the chat sound is off when I login. After I turn on the chat sound, upon refreshing, the chat sound is reset to off.

I have tried my hand at this problem, and I saw the various settings in settings.ts file, but I don't know how to change it for the docker image.

Thank you.

yesBad commented 2 years ago

You have to edit the source-code and build the docker image.

Building instructions can be found here.

reformedp commented 2 years ago

Just to clarify, other items in settings such as "Scroll Sensitivity", "Invert Scroll", "Ignore Emotes" are able to persist between refreshes. Only "Play Chat Sound" does not persist. I am using firefox, if that matters.

Also, in settings.ts line 18, chat sound already seems to be initialised to true.

I am not too sure how to approach this issue.

yesBad commented 2 years ago

Just to clarify, other items in settings such as "Scroll Sensitivity", "Invert Scroll", "Ignore Emotes" are able to persist between refreshes. Only "Play Chat Sound" does not persist. I am using firefox, if that matters.

Also, in settings.ts line 18, chat sound already seems to be initialised to true.

I am not too sure how to approach this issue.

Oh I didn't even realize that they persisted, that's interesting that it exactly doesn't persist. But you could just simply modify the docker image in the line 18 of the settings.ts file you found and then rebuild the docker image and be good to go

reformedp commented 2 years ago

Thanks for pointing out how to modify the docker image. I have found the line to modify: it is app.vue line 186. Seems like hideControls is activated when loading the page.

m1k1o commented 2 years ago

Just to clarify, other items in settings such as "Scroll Sensitivity", "Invert Scroll", "Ignore Emotes" are able to persist between refreshes. Only "Play Chat Sound" does not persist. I am using firefox, if that matters.

Seems like a bug, I'll take a look at it.

m1k1o commented 2 years ago

It should be fixed now, Play Chat Sound is again persistent as all other settings.

reformedp commented 2 years ago

Thank you, the issue is fixed.