m1k1o / neko

A self hosted virtual browser that runs in docker and uses WebRTC.
https://neko.m1k1o.net/
Apache License 2.0
5.98k stars 449 forks source link

Possible to change listen port from 8080? #161

Closed taskvalanche closed 2 years ago

taskvalanche commented 2 years ago

I was planning on giving this a whirl on my VPS, the problem is I have port 8080 in use by another service that can't be reconfigured - 8080 is baked into it. I looked through the code to find a configurable option to change it and located the variable NEKO_BIND which I attempted to set in the docker-compose file to 8090. The container starts but I get the following error even if I try the NEKO_IP or NEKO_NAT1TO1 options as well:

PNC unable to start http server error="listen tcp: address 8090: missing port in address" module=http

I figured it probably wouldn't work as I was going a bit off the beaten path there, and if 8080 is baked into the system and not changable that's fine, but is there a way to move the default binding port off 8080?

m1k1o commented 2 years ago

It needs whole address to bind to, so e.g. 0.0.0.0:8090, shortcut for it would be :8090 (note leading :, as empty ip is implicitly all zeroes).

taskvalanche commented 2 years ago

That did it, awesome, thanks! Works great now. Something so simple, I'm still a bit new with Docker. This will make an awesome testing tool for me.