Why does client.supported check `addTransceiver` existence

m1k1o / neko

A self hosted virtual browser that runs in docker and uses WebRTC.

https://neko.m1k1o.net/

Apache License 2.0

5.98k stars 449 forks source link

Why does client.supported check `addTransceiver` existence #166

Open liorsbg opened 2 years ago

liorsbg commented 2 years ago

Hello,

I was wondering why client.supported() checks for RTCPeerConnection.prototype.addTransceiver. (code)

It looks like addTransceiver isn't actually used anywhere. I suspect (will test soon) that neko could actually work on slightly older browsers and that this guard is overly aggressive.

Any idea why this is the supported test? What am I missing?

m1k1o commented 2 years ago

Hello, I don't know if there is some special reason for that, added in https://github.com/m1k1o/neko/commit/3a46fa43e6ddefa43fa581c135603011a755bd9a. Backwards compatibility has never been a priority, all users are encoruaged to use latest browsers to get the best performance.

mbattista commented 2 years ago

To add to @m1k1o answer https://caniuse.com/?search=addTransceiver shows no difference in older browser versions.