[BUG] Guacamole keyboard resend invalid characters

[gbrian]

Hi,

When writting and astherisk, SHIFT+*, guacamole keyboard gets stuck and starts resend invalid characters.

Looks like the issue is here: https://github.com/m1k1o/neko/blob/c48309b6485a816789589ff7115a9bc4e4340000/client/src/utils/guacamole-keyboard.js#L845

[m1k1o]

What keyboard layout do you use on your host and inside neko? Is it everywhere US as shown bottom right in vscode?

[gbrian]

Yes, US

[m1k1o]

There has been updates in guacamole upstream codebase. I upgrade it and see if that fixes the issue.

[m1k1o]

@gbrian can you retest with latest change? Also whole keyboard, if something changed.

[gbrian]

Hi, Unless did something wrong, I've pulled latest image and tested, same behaviour. Testing some changes on Guacamole.keyboard. I'll keep you posted.

CAUGHT!

Basically it happens when you release SHIFT key before the character pressed. In this case weh want to sent a ":" (Semicolon) that's SHIFT + . (shift + period) on ES keyboard:

• I press the combination SHIFT + . (shift + period):
  • A SHIFT keydown is sent to server
  • A : (semicolon) keydown is sent to server
• Then I release SHIFT KEY
  • A SHIFT keyup is sent to server
• Then I release the "." (period) key
  • A . (period) keydown is sent to server

At this point the server keeps thinking ":" (semicolon) still pressed Guacamole has a timeout and finally sends a "keyup" for the ":" (semicolon)

[gbrian]

Pushed new changes for a fix (workaround) https://github.com/m1k1o/neko/pull/178