m1k1o / neko

A self hosted virtual browser that runs in docker and uses WebRTC.
https://neko.m1k1o.net/
Apache License 2.0
5.96k stars 449 forks source link

The possibility to auto hide the top and bottom bars #254

Closed ghost closed 1 year ago

ghost commented 1 year ago

Can this feature be added? The possibility to auto hide the top and bottom bars

m1k1o commented 1 year ago

There is fullscreen button, or if you visit the page with ?cast=1 then only video feed is visible. But I suspect you want to have chat visible, right?

ghost commented 1 year ago

?cast=1 did work when trying now. however, doesn't allow me to take control of the keyboard to start using.

I would like to have it fullscreen directly or autohide just to be able to use the video feed as a second browser

m1k1o commented 1 year ago

Or you could start neko with NEKO_IMPLICIT_CONTROL=true and you don't need to take control every time. This might fit your use-case.

ghost commented 1 year ago

Worked :)

However, the fullscreen icon of the video is not showing using ?cast=1 as it just hides the bars but doesn't fullscreen the video , how would I full screen it or toggle the fullscreen for the video itself?

On Wed, Feb 22, 2023 at 8:05 AM Miroslav Šedivý @.***> wrote:

Or you could start neko with NEKO_IMPLICIT_CONTROL=true and you don't need to take control every time. This might fit your use-case.

— Reply to this email directly, view it on GitHub https://github.com/m1k1o/neko/issues/254#issuecomment-1439583092, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD46DPPQKNCVZ5D6JPUVIW3WYXCC3ANCNFSM6AAAAAAVD5PQCA . You are receiving this because you authored the thread.Message ID: @.***>

m1k1o commented 1 year ago

Yes that is clearly missing in GUI for ?cast=1 but you can just full-screen whole tab since there is nothing else, or?

ghost commented 1 year ago

it doesn't fullscreen the video, still shows the browser tabs, bookmarks, and the url bar.

can the screen resolution icon/button and the fullscreen icon/button be visible when using ?cast=1 ?

On Wed, Feb 22, 2023 at 9:39 AM Miroslav Šedivý @.***> wrote:

Yes that is clearly missing in GUI for ?cast=1 but you can just full-screen whole tab since there is nothing else, or?

— Reply to this email directly, view it on GitHub https://github.com/m1k1o/neko/issues/254#issuecomment-1439706329, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD46DPMHJAQ5BWG4US3DRKDWYXNETANCNFSM6AAAAAAVD5PQCA . You are receiving this because you authored the thread.Message ID: @.***>

m1k1o commented 1 year ago

That could be added. Yes.

ghost commented 1 year ago

That's really great :) and I really like your work, this repo/project is the best!. better than webtop and all other alternatives.

On Wed, Feb 22, 2023 at 7:30 PM Miroslav Šedivý @.***> wrote:

That could be added. Yes.

— Reply to this email directly, view it on GitHub https://github.com/m1k1o/neko/issues/254#issuecomment-1440681965, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD46DPMSV7NRHWGPNB6PYP3WYZSOTANCNFSM6AAAAAAVD5PQCA . You are receiving this because you authored the thread.Message ID: @.***>

ghost commented 1 year ago

Thanks a lot :), or they could even be just added maybe as keyboard shortcuts so that it wouldn't take space :)

On Wed, Feb 22, 2023 at 7:30 PM Miroslav Šedivý @.***> wrote:

That could be added. Yes.

— Reply to this email directly, view it on GitHub https://github.com/m1k1o/neko/issues/254#issuecomment-1440681965, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD46DPMSV7NRHWGPNB6PYP3WYZSOTANCNFSM6AAAAAAVD5PQCA . You are receiving this because you authored the thread.Message ID: @.***>

m1k1o commented 1 year ago

Added controls for ?cast=1: image

ghost commented 1 year ago

@m1k1o you are the best ;)

alanmilinovic commented 1 year ago

If the right menu is displayed and you add ?cast=1, it will not hide it and you will not be able to close the menu.

This is only happening on mobile device.

Screenshot_20230225_071709_Chrome

Also not sure why menu is not closed automatically once you logout.

m1k1o commented 1 year ago

This looks like some forgotten styles for mobile devices for ?cast=1. Thanks for pointing out!