search

m1k1o / neko

A self hosted virtual browser that runs in docker and uses WebRTC.
https://neko.m1k1o.net/
Apache License 2.0
5.96k stars 449 forks source link

add url param for disabling audio at begining. #261 #265

Closed urbanekpj closed 1 year ago

urbanekpj commented 1 year ago

see #261 PR add option to disable audio at beggining on client side. stat muted but also don't show muteOverlay, assuming audio will be played on different device. and it will be displayed with cast option.

m1k1o commented 1 year ago

I'd rename to ?muted=1 or maybe ?volume=<number> where user could choose own volume. Not sure if that would have any usecase, but if ?volume=0 it would simply mean muted, and ?volume=1 is maximum as usual. What do you mean?

Because this does not really disable audio. That would need to be propragated to server-side, so that it never actually sends audio track to the client. This could reduce latency, because video would not need to be synced with audio. That would be a different feature. Or if you wish to imlement this feature, that'd be also great.

urbanekpj commented 1 year ago

i like volume param. it is simpler. i volume=0.0 then audio is not playing and not mutedOverlay is visible.

about use case. i have two devices. one large display(cast=1 audio video, no controls) and second smaller embedded device touch interface( implicit control, no audio). desired configuration is that smaller device will have no audio and no additional controls or overlays. so i need volume=0 on client device not on server. because audio will be played on 'large' display.

ps i didn't set mute = true when volume=0 to not show muted overlay. it will be automatically set when it will bo impossible to play audio automatically.