search

m1k1o / neko

A self hosted virtual browser that runs in docker and uses WebRTC.
https://neko.m1k1o.net/
Apache License 2.0
7.11k stars 524 forks source link

Add option to lock client remote on login #375

Closed FapFapDragon closed 6 months ago

FapFapDragon commented 6 months ago

One liner to lock client controls on join. Mostly useful when NEKO_IMPLICIT_CONTROL is set. Users joining will not be controlling but have the option. In YAML:

NEKO_LOCKS: "remote"

Let me know if you don't like how I've done this.

m1k1o commented 6 months ago

Locks are mainly used for server-side locking. There are also missing translations for that lock:

image

As this happens only on the client side and is never synchronized with the server (the lock cannot be actually changed) I think that this is more like a GUI option rather than a new lock.

Along with configuring such settings as default volume, default keyboard we could define that it is locked by default. This would need a way how to configure client from server settings, by e.g. adding configuration json endpoint that is loading everytime when gui is started.

FapFapDragon commented 6 months ago

Thanks for the feedback, That makes sense.

I suppose the JSON could be an option, and I didn't notice the missing translations, so good catch.

I'm going to close this pull request and may come back to this later (I really only needed this change for my groups personal instance so I can build from my fork for that).