search

m1l / Everything-Metric

Edge (Chromium) and Chrome Extension for converting USCS sites to Metric / SI
62 stars 15 forks source link

Pounds vs lbs #24

Open willthong opened 2 years ago

willthong commented 2 years ago

Can we please have an option to disable conversion of "3 pounds" (the extension would only convert "3 lbs" if it were switched on)? This would avoid accidental conversion of "3 pounds" (when the author intends £3, or 3 pounds sterling). Thank you!

kazerniel commented 2 years ago

Yeah I just ran into this too, converted even with the actual £ sign.

image

k0-ba commented 2 years ago

same with Hungarian forint (HUF). Forint has a short form "Ft" or "ft". Which is exactly the same as feet (ft).

On Sun, 4 Sept 2022 at 15:36, kazerniel @.***> wrote:

Yeah I just ran into this too, converted even with the actual £ sign.

[image: image] https://user-images.githubusercontent.com/5689996/188316368-a4c49595-3cd5-48ec-b7bb-081353219942.png

— Reply to this email directly, view it on GitHub https://github.com/m1l/Everything-Metric/issues/24#issuecomment-1236343852, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGKX2CPEEO7KYR45W2BDEALV4SQWFANCNFSM576LIN7A . You are receiving this because you are subscribed to this thread.Message ID: @.***>

--

Bálint Kőszegi freelance http://bit.ly/39py94O researcher UX/SD/data/psychology

kazerniel commented 2 years ago

same with Hungarian forint (HUF). Forint has a short form "Ft" or "ft". Which is exactly the same as feet (ft).

yea, also mentioned that issue here https://github.com/m1l/Everything-Metric/issues/6#issuecomment-1256085532

m1l commented 2 years ago

I can add options to disable if it has lang="hu" (I am not sure if all Hungarian sites have language flag correctly set in source) The other, improvised ways would be to add option to [] Disable converting "Ft" I don't have much time now so unless one of you can add the filter and send pull request, it might have to wait a while until I find some time. In the meantime, you can turn off turn off extension by clicking on it, and then when you need it, just press Alt+M to convert current page without turning on the extension

m1l commented 2 years ago

Edit: I see this one is for pounds. Please open different issues for different things. For pounds I can add option to turn off parsing the word "pounds", unless you know that it is always written with the pound sign in front of number followed by the word, in that case it could probably lookahead for that sign. The world is a mess.