m1l / Everything-Metric

Edge (Chromium) and Chrome Extension for converting USCS sites to Metric / SI
59 stars 15 forks source link

Another edge case on etsy.com when using non-us currency where one value stops converting #30

Open Chad90b opened 1 year ago

Chad90b commented 1 year ago

for some reason when you change currency on etsy.com this can happen. i cannot see why it would but it ignores the last measurement for this page in my example below:

with default usd currency it looks fine: image

but non-default non-us currency breaks the conversion for some reason: image

here is an example page https://www.etsy.com/listing/1234651516/ currency can be selected from the bottom left of the page

m1l commented 1 year ago

That is because unit is followed by (number as that is how sites that already provide conversions put their units ex: 1" (25.4 mm) to avoid double conversion. It would be too complicated to parse also the units in brackets making sure those are metric

Chad90b commented 1 year ago

thank you for the explanation! i understand the reasoning behind the decision. is this an option that can be toggled?