search

m1ome / iso8583

PHP ISO8583 pack/unpack library
MIT License
14 stars 17 forks source link

Fix bitmap base conversion #1

Closed kaperys closed 7 years ago

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-1.03%) to 91.011% when pulling d948006307d53f339bfad5bffaf32fe2cdfb36a3 on kaperys:master into f919fa22b85e80eaaa6b16eaa59a3554622e1598 on m1ome:master.

m1ome commented 7 years ago

@kaperys can you provide some additional test over this issue. I mean it would be awesome if it will be covered in test suite. Thank you!

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 92.045% when pulling cfc1d96e4eecdb6ba293e661d6ef5515a56e007f on kaperys:master into f919fa22b85e80eaaa6b16eaa59a3554622e1598 on m1ome:master.

kaperys commented 7 years ago

@m1ome I've removed the bitmap length check that that was causing the coverage to drop (it never got hit because the padding happens when the base is converted from 16 to 2)

m1ome commented 7 years ago

@kaperys I mean not improve code coverage, but to provide case in test suite that covers your issue.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+1.2%) to 93.258% when pulling 0ca112278bd907637368ca721d411ca9c6231d5c on kaperys:master into f919fa22b85e80eaaa6b16eaa59a3554622e1598 on m1ome:master.

kaperys commented 7 years ago

@m1ome sorry, covered! I've also added a couple of example files which I've been using whilst playing around

m1ome commented 7 years ago

@kaperys Awesome thank you for a job!