m1oojv / pe

0 stars 0 forks source link

Incorrect error message #11

Open m1oojv opened 8 months ago

m1oojv commented 8 months ago

Screenshot 2023-11-17 at 4.40.22 PM.png

The error message implies that my input for the role is wrong but its that it did not account for invalid flags

nus-pe-bot commented 7 months ago

Team's Response

Hi tester, thank you for pointing this out. The parser in our application identifies flags with the correct format, e.g. n/, p/, e/, instead of identifying for / only. Otherwise, every instance of ANY_LETTER/ will be considered as a flag, which poses a problem in our parser.

As such, the role in your function is indicated to be 'PaTient f/'.

However, we do agree that it is not likely for users to indicate the role with / but might be referring to an incorrect tag, so improving the output message is a possible improvement that we can work on in the future.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: Screenshot 2023-11-22 at 1.09.08 AM.png

As shown from the module website, this is a valid bug to be reported as a Feature Flaw.

Lack of proper handling of potentially invalid inputs, Not detecting easy to detect incorrect flags are mentioned in the module website to be valid bugs to be reported


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]