m1oojv / pe

0 stars 0 forks source link

SD diagram exceeds the SD box #25

Open m1oojv opened 7 months ago

m1oojv commented 7 months ago

Screenshot 2023-11-17 at 5.17.30 PM.png

I think the objects can be inside the diagram

soc-pe-bot commented 7 months ago

Team's Response

Thanks for pointing this out tester! We intend to improve this in the future, but currently, this is a limitation of the UML code. We were unable to get Model and DeleteCommand into the frame. We think this does not affect readability of the diagram, although we acknowledge that in the future we could find a way so that the frame contains the objects.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: Screenshot 2023-11-22 at 12.30.49 AM.png

I do not think Not in scope is the proper response to this bug as I feel that the correctness of the reference diagram is vital and "important enough to be in this version of the application ans is missing"

In fact, my team managed to use PlantUML to easily place the Model and Delete Command into the reference box, so there seems of be a lack of effort from the dev team to ensure that their diagrams are accurate (which can be seen from their numerous other bugs on their other diagrams in the DG - making their DG almost unusable due to the number of inaccuracies) . Even if the dev team did not know how to use PlantUML to structure their diagrams, there is always to forum to ask other developers for help on how it is suppose to be done. Thus, I think this is a valid bug to be reported as it does not require a lot of effort to gain the knowledge needed to correct this diagram.

I think the incorrect format of the reference diagram is a significant and valid documentation bug as it may cause confusion to the user and hinder the user in reading the diagram (user requiring more effort than usual in order to decipher the diagram)

Screenshot 2023-11-22 at 12.38.04 AM.png