m1oojv / pe

0 stars 0 forks source link

Inconsistent use of colours of diagrams #28

Open m1oojv opened 8 months ago

m1oojv commented 8 months ago

Screenshot 2023-11-17 at 5.21.13 PM.png

why is the above diagram different colours to below diagram. do the colours mean different things

nus-pe-bot commented 7 months ago

Team's Response

Hi tester, thank you for catching this. However, we think that diagrams having different colours do not pose an issue. They are two different diagrams that serve different purposes.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I still think that this is a cosmetic issue due to the inconsistencies in the colours use in all your UML diagrams. The sudden change in colours used may cause developers confusion and spend more time on this diagram when it does not mean anything.

Therefore, I think this is still a documentation bug that is purely cosmetic , thus severity very low.

In fact I think that Rejection should not be the correct response from the dev team.

Screenshot 2023-11-22 at 12.26.12 AM.png

According to prof, rejection of bugs are only for bugs that should not be carried out in the DG at all, now or later. However, i think it is agreed that proper formatting of the diagrams with the same colours should be something that the team strives towards and thus this bug should be accepted by the dev team.

Additionally, it is stated in the course website that any choices made by the team should be consistent throughout the documentation

Screenshot 2023-11-22 at 11.55.32 AM.png

Additionally, this issue is also not limited to only one UML diagram in your DG. As seen below your other diagrams also do not follow one standard format throughout the documentation. Screenshot 2023-11-22 at 11.57.36 AM.png

Screenshot 2023-11-22 at 11.56.35 AM.png