m1oojv / pe

0 stars 0 forks source link

All data is deleted after exiting application after invalid json file is given #3

Open m1oojv opened 8 months ago

m1oojv commented 8 months ago

Screenshot 2023-11-17 at 4.20.56 PM.png

after exit , all data is deleted

Screenshot 2023-11-17 at 4.21.16 PM.png

This is very dangerous for users , especially non tech savvy ones to have their data entirely wiped out because of an error in the json file

nus-pe-bot commented 7 months ago

Team's Response

Hi tester. It is already mentioned in the UG that any error in the JSON file will result in the clearing of the data to prevent error:

image.png

This mechanism is to ensure that erroneous data will not be allowed for use that may lead to catastrophic scenarios like important data lost after adding on to the problematic data. If users are non tech savvy, they should not be modifying the JSON file unless they know what they are doing.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I must respectfully challenge the decision to reject the issue concerning the potential for data loss upon modifying the data file with an invalid input. The possibility that a single erroneous change could result in the loss of a substantial contact list—up to 1000 entries as specified in the Non-Functional Requirements—is a matter of considerable concern, particularly in a hospital setting where such data is crucial for daily operations. I was going to give this a high severity but because of I have already considered the warning included in the UG, I have downgraded it to medium.

While the warning in the User Guide is an important advisory, it may not suffice in mitigating the risks posed by this issue. The primary users of this application, head nurses, may not possess the technical expertise required to navigate such problems safely. Therefore, relying on their vigilance and understanding of technical documentation to prevent data loss is not a fail-proof strategy. The application should be designed to be resilient to user errors, particularly when the stakes involve critical patient and staff data.

The proposed solution of archiving the save file, rather than discarding it, is indeed a prudent measure. However, the effectiveness of this solution is contingent upon the users' awareness and understanding of how to utilize such a feature. Given that the current User Guide does not provide instructions on this process, the risk of data loss remains unmitigated for the non-technical user.

Data management within a healthcare application is not a trivial matter; it is integral to the application's core functionality. The potential loss of data due to an accidental misstep is a severe concern that demands attention and rectification. It is not a question of whether the bug should be addressed now or later, but rather the necessity of ensuring the application fulfills its role reliably and securely without the risk of such catastrophic failures.

Moreover, as per the guidance provided by the professor, rejection of bugs should be reserved for issues that are deemed irrelevant or unnecessary to the product in any future context. In this case, the integrity of data and the usability of the application for non-technical users are clearly relevant and require consideration.

Screenshot 2023-11-22 at 9.56.52 AM.png

In light of these points, I urge the development team to accept this bug and prioritize the implementation of a solution that safeguards user data effectively and ensures that the application adheres to the high standards required for medical software.


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** I was going to give this a high severity but because of I have already considered the warning included in the UG, I have downgraded it to medium. While I acknowledge the warning included in the User Guide about modifying the data file, the potential loss of up to 1000 contacts due to a single invalid input is a matter that warrants serious concern. Given the nature of the application's use in healthcare settings, where data integrity is paramount, the severity of this issue is more substantial than currently classified. Impact on User Operations: The loss of a large contact list represents a significant disruption to hospital operations. Nurses and healthcare professionals rely on the availability and accuracy of contact information for efficient patient care and internal communication. An error that could wipe such critical data is far from a minor inconvenience. User Base Consideration: The target users of the application—head nurses—are professionals who may not be technically inclined. Expecting them to understand the intricacies of data files or to manually archive potentially corrupted data is not practical. The User Guide should provide clear, non-technical instructions for recovery in the event of such errors. Data Recovery: The suggestion to archive rather than discard the save file is a viable solution that could mitigate the issue. However, the lack of instructions for this process in the User Guide means that users may not be aware of this safeguard. The absence of such critical guidance can exacerbate the consequences of data loss. Non-Functional Requirements (NFR): The application’s NFR specifies support for up to 1000 contacts, implying an expectation of robust data handling. The current behavior when encountering invalid inputs does not align with this requirement, as it risks extensive data loss that could be catastrophic in a healthcare management context. In light of these considerations, I maintain that the issue should be classified at least as medium severity. While I agree that it is a bug that needs to be addressed, its potential impact on hospital management and patient care due to data loss is too significant towards all users to be considered low severity. ![Screenshot 2023-11-22 at 10.03.11 AM.png](https://raw.githubusercontent.com/m1oojv/pe/main/files/3c5cda11-fca6-44e1-96ba-f951ed7fe55a.png)