search

m2-farzan / ros2-galactic-PKGBUILD

AUR Package for ROS 2 Galactic
11 stars 11 forks source link

Upgrade to ROS 2 Galactic Geochelone - Patch Release 1 #3

Closed YuanYuYuan closed 2 years ago

YuanYuYuan commented 2 years ago

Hi, @m2-farzan ,

Thanks for your awesome AUR first. I made this to upgrade to the latest patch of Galactic, including

  1. Update some ROS2 packages to the commit that resolves the building bugs.
  2. Since yay would fail to run after upgrade to the latest Arch due to this issue. I personally suggest using another one that updates frequently.
  3. I notice you move the PyQt5 symlink to _preinstall() in ros2-galactic.install, but it would cause those compiling depending on PyQt fail. Because _preinstall() runs before the extraction of the built package but after the makepkg building is finished.

BTW, I had tested the PKGBUILD inside a docker environment.

Cheers,

Yuyuan

m2-farzan commented 2 years ago

Nice! Thanks for your contribution. Looks good to me.