m2-farzan / ros2-galactic-PKGBUILD

AUR Package for ROS 2 Galactic
11 stars 11 forks source link

Fix pyqt/sip4 compatibility issue #36

Closed ruffson closed 1 year ago

ruffson commented 1 year ago

Fix for #9 by replacing sip4 and ros2-pyqt5-sip-compat deps with python-pyqt5-sip4 as suggested in the linked issue. Confirmed working on my machine when installing ros2-galactic (with paru).

m2-farzan commented 1 year ago

Testing:

First attempt: https://github.com/m2-farzan/ros2-galactic-PKGBUILD/actions/runs/4095644618

m2-farzan commented 1 year ago

@ruffson thanks for the lovely patch and sorry for the delay. The tests have failed but it's due to a problem with another AUR package. So despite the error, I've pushed this change to AUR. I'll port the patch to humble and rolling packages too.

ruffson commented 1 year ago

@ruffson thanks for the lovely patch and sorry for the delay. The tests have failed but it's due to a problem with another AUR package. So despite the error, I've pushed this change to AUR. I'll port the patch to humble and rolling packages too.

Of course! Thank you for all the work on this, it is much appreciated!