search

m2049r / xmrwallet

monerujo: An Android Monero Wallet
https://www.monerujo.io/
Apache License 2.0
598 stars 274 forks source link

Failed Transaction options feature #648

Open dscotese opened 4 years ago

dscotese commented 4 years ago

Sometimes a transaction is reported as "Failed." It seems the best way to handle this is to try it again a few minutes later or maybe to send it through a different peer. This is a request to add feature for such transactions: a "Retry" button which uses whichever is the most commonly successful solution. For me, it has been switching nodes, but my sample size is unreasonably small.

m2049r commented 3 years ago

does this happen often to you? how do you do it? i have never seen a real failed transaction ever.

NB that sometimes a tx reports as failed and then goes through nonetheless - this was the case last year when dandilion was introduced until they fixed it. so retrying it would execute it twice.

dscotese commented 3 years ago

It may have been fixed as a side effect of something other fix regarding network connectivity, timeouts, keepalives, or something like that. I haven't seen it much recently. I think a lot of time it wasn't a real failed transaction, but rather an assumption in the code about the public node I was using that was wrong. It often happened after I hadn't used the wallet for a while, but hadn't disconnected and reconnected to a node either.

chaserene commented 2 years ago

I've had my first ever failed transaction with 2.2.1 and have no idea how it happened. attempting a resend gave me a doublespend error. I had to log out, switch nodes and log in to be able to send it. please let us know if you figure out a way to prevent this.