Closed ghost closed 3 years ago
There is one other PR for arabic I found from 2018. Might be good to compare. Seems there were some problems with RightToLeft language support but it may be prepared now https://github.com/m2049r/xmrwallet/pull/423
If I only knew about this. I checked the translation and it's good aside from spelling "mistakes". One interesting tranlation difference is that of mneumonic seeds. I translated it literally while he translated it as "recovery words". I think my translation is a bit better and I hope the RTL issue is fixed :)
Some screenshots of app (I don't know arabic, but as I see (and with force RTL + English) there is no issues). But there is still some untranslated strings. @phwright should still check app for RTL issues My compiled testnet APK: https://skyportal.xyz/AACf2tBrS7ItQ7UYpcviWzthPnSqWVUIppYs_OMVh432aA
looks good! However, I can't install your APK. I tried it on two different phones, an lg g6 and a samsung galaxy note 4 with a custom rom, and both didn't install it.
and both didn't install it.
Its only for x86_64 emulator. Universal apk: https://skyportal.xyz/AACkmJMAFFNiLG_V4hIr_-Pz2aD4Dj179TFhZGOoo9rZfQ (but build your own is better)
I add the new strings and fixed some typos. should be good now.
Replace rows 481-484 with
<string name="tx_details_notes" translatable="false"><span style=\"background-color: #%1$s; color: #%2$s;\"> %3$s </span>%4$s</string>
<string name="receive_subaddress" translatable="false"><span style=\"background-color: #%1$s; color: #%2$s;\"> %3$s </span> %4$s</string>
Build should pass
cool!
please remove entries with translatable="false"
.
the build breaks because you have used
in strings.xml
but that is an non translatable string anyway. so all will be good when you remove those entries.
thanks!
should I remove just the lines with translatable="false" or their contents as well such as
<!-- order must be the same as in com.m2049r.xmrwallet.data.Crypto-->
<string-array name="cryptos" translatable="false">
<item>Monero</item>
<item>Bitcoin</item>
<item>Dash</item>
<item>Dogecoin</item>
<item>Ethereum</item>
<item>Litecoin</item>
</string-array>
with contents - thanks
done!
A translation from a while back. All the text is translated but it might need some polishing.