m2049r / xmrwallet

monerujo: An Android Monero Wallet
https://www.monerujo.io/
Apache License 2.0
617 stars 273 forks source link

Arabic Translation #767

Closed ghost closed 3 years ago

ghost commented 3 years ago

A translation from a while back. All the text is translated but it might need some polishing.

ghost commented 3 years ago

There is one other PR for arabic I found from 2018. Might be good to compare. Seems there were some problems with RightToLeft language support but it may be prepared now https://github.com/m2049r/xmrwallet/pull/423

ghost commented 3 years ago

If I only knew about this. I checked the translation and it's good aside from spelling "mistakes". One interesting tranlation difference is that of mneumonic seeds. I translated it literally while he translated it as "recovery words". I think my translation is a bit better and I hope the RTL issue is fixed :)

katant commented 3 years ago

Some screenshots of app (I don't know arabic, but as I see (and with force RTL + English) there is no issues). But there is still some untranslated strings. Screenshot_1620635788 Screenshot_1620635870 Screenshot_1620635913 Screenshot_1620635925 Screenshot_1620635936 @phwright should still check app for RTL issues My compiled testnet APK: https://skyportal.xyz/AACf2tBrS7ItQ7UYpcviWzthPnSqWVUIppYs_OMVh432aA

ghost commented 3 years ago

looks good! However, I can't install your APK. I tried it on two different phones, an lg g6 and a samsung galaxy note 4 with a custom rom, and both didn't install it.

katant commented 3 years ago

and both didn't install it.

Its only for x86_64 emulator. Universal apk: https://skyportal.xyz/AACkmJMAFFNiLG_V4hIr_-Pz2aD4Dj179TFhZGOoo9rZfQ (but build your own is better)

ghost commented 3 years ago

I add the new strings and fixed some typos. should be good now.

katant commented 3 years ago

Replace rows 481-484 with <string name="tx_details_notes" translatable="false">&lt;span style=\"background-color: #%1$s; color: #%2$s;\"&gt;&nbsp;%3$s&nbsp;&lt;/span&gt;%4$s</string> <string name="receive_subaddress" translatable="false">&lt;span style=\"background-color: #%1$s; color: #%2$s;\"&gt;&nbsp;%3$s&nbsp;&lt;/span&gt;&nbsp;&nbsp;%4$s</string> Build should pass

m2049r commented 3 years ago

cool! please remove entries with translatable="false". the build breaks because you have used &nbsp; in strings.xml but that is an non translatable string anyway. so all will be good when you remove those entries. thanks!

ghost commented 3 years ago

should I remove just the lines with translatable="false" or their contents as well such as

<!-- order must be the same as in com.m2049r.xmrwallet.data.Crypto-->
    <string-array name="cryptos" translatable="false">
        <item>Monero</item>
        <item>Bitcoin</item>
        <item>Dash</item>
        <item>Dogecoin</item>
        <item>Ethereum</item>
        <item>Litecoin</item>
    </string-array>
m2049r commented 3 years ago

with contents - thanks

ghost commented 3 years ago

done!