m2049r / xmrwallet

monerujo: An Android Monero Wallet
https://www.monerujo.io/
Apache License 2.0
617 stars 273 forks source link

Use multi-stage docker builds #842

Open mstniy opened 2 years ago

mstniy commented 2 years ago

This would lead to a smoother, more optimized build process for the containers. Currently they all download very similar packages (zmq, sodium, openssl etc.) but these are below the installation of the android toolchain in the Dockerfiles, so they get re-run for each container build.

m2049r commented 2 years ago

not sure how you mean this. each build builds for a different target and so these layers cannot be reused. there are also dependencies between the packages. caching works fine and rebuilding after a change in monero only rebuilds monero.