Xml updates for YOG - Githubissues

m2lines / CAM-ML

Community Atmosphere Model

0 stars 0 forks source link

Xml updates for YOG #2

Closed jatkinson1000 closed 2 weeks ago

jatkinson1000 commented 3 months ago

Closes #1

This PR:

adds YOG as an option for the deep scheme
creates namelist variables for SAM_sounding and nn_weights filepaths
creates a namelist variable to control running both schemes for comparative results
Adds these variables to the CAM code to be read in from namelists and assigned

jatkinson1000 commented 3 months ago

This branch has successfully been built on Derecho and the new variables checked by supplying 'inappropriate' inputs.

jatkinson1000 commented 3 months ago

Discussion point - to keep in the spirit of CESM we should look at having a yog_conv_readnl function as part of the interface to keep phys_control clean. This would be responsible for defining the namelist file variables.

Would require moving the group assignment in the xml.

dorchard commented 2 months ago

https://github.com/m2lines/CAM-ML/pull/9 now overlaps a little with this and makes some different choices. The plan is to merge this branch into CAM-ML and deal with the conflicts generated by https://github.com/m2lines/CAM-ML/pull/9 later.