m2lines / L96_demo

Lorenz 1996 two time-scale model for learning machine learning
https://m2lines.github.io/L96_demo
MIT License
33 stars 18 forks source link

New/sindy eq discovery #111

Closed IamShubhamGupto closed 1 year ago

IamShubhamGupto commented 1 year ago

Update:

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

dhruvbalwada commented 1 year ago

Looks like this failed because of the same problem as #109 (which we tried to fix in #110). I hope the author can given us some useful advice.

IamShubhamGupto commented 1 year ago

@dhruvbalwada

it failed again for the same error, PRs from forks cannot get a preview, Im asking the authors if there's a way to go around this

Error: Resource not accessible by integration
dhruvbalwada commented 1 year ago

One easy solution is to give you higher level permissions on repo, would that be fine?

IamShubhamGupto commented 1 year ago

Hey @dhruvbalwada

Based on the reply here - https://github.com/rossjrw/pr-preview-action/discussions/48#discussioncomment-5821256

The fork and pull method which we are using is not supported, I did not think of this when I was suggesting the idea.

We could:

  1. Continue going without pr-previews until a solution shows up in the future
  2. We get write access directly to the repository, our PRs will originate from other branches within m2lines/L96demo rather than our forks
  3. As the author suggested, we use external apps like Netlify which I tried setting up for my personal project but could not figure out how to get pr-previews working, if anyone else knows, maybe they could join in and help
dhruvbalwada commented 1 year ago

Let's go with 1 for now, and we can figure something better out for the summer in June.

IamShubhamGupto commented 1 year ago

@dhruvbalwada Sure, I am going to remove preview.yml in this branch and we should be back to how things were going before

I will be keeping requirements.txt as we now have pip dependencies