m2lines / L96_demo

Lorenz 1996 two time-scale model for learning machine learning
https://m2lines.github.io/L96_demo
Other
36 stars 20 forks source link

Numba warnings #120

Closed IamShubhamGupto closed 1 year ago

IamShubhamGupto commented 1 year ago

Problem

with the latest commit, there seems to be a new numba deprecation warning generated from methods in'L96_model and DA_methods file.

Logs

source: Learning Data Assimilation Increments notebook

/home/runner/work/L96_demo/L96_demo/notebooks/DA_methods.py:10: NumbaDeprecationWarning: The 'nopython' keyword argument was not supplied to the 'numba.jit' decorator. The implicit default value for this argument is currently False, but it will be changed to True in Numba 0.59.0. See https://numba.readthedocs.io/en/stable/reference/deprecation.html#deprecation-of-object-mode-fall-back-behaviour-when-using-jit for details.
  def Lin3dvar(ub, w, H, R, B, opt):
/home/runner/work/L96_demo/L96_demo/notebooks/DA_methods.py:39: NumbaDeprecationWarning: The 'nopython' keyword argument was not supplied to the 'numba.jit' decorator. The implicit default value for this argument is currently False, but it will be changed to True in Numba 0.59.0. See https://numba.readthedocs.io/en/stable/reference/deprecation.html#deprecation-of-object-mode-fall-back-behaviour-when-using-jit for details.
  def ens_inflate(posterior, prior, opt, factor):
/home/runner/work/L96_demo/L96_demo/notebooks/DA_methods.py:59: NumbaDeprecationWarning: The 'nopython' keyword argument was not supplied to the 'numba.jit' decorator. The implicit default value for this argument is currently False, but it will be changed to True in Numba 0.59.0. See https://numba.readthedocs.io/en/stable/reference/deprecation.html#deprecation-of-object-mode-fall-back-behaviour-when-using-jit for details.
  def EnKF(prior, obs, H, R, B):
/home/runner/work/L96_demo/L96_demo/notebooks/L96_model.py:12: NumbaDeprecationWarning: The 'nopython' keyword argument was not supplied to the 'numba.jit' decorator. The implicit default value for this argument is currently False, but it will be changed to True in Numba 0.59.0. See https://numba.readthedocs.io/en/stable/reference/deprecation.html#deprecation-of-object-mode-fall-back-behaviour-when-using-jit for details.
  def L96_eq1_xdot(X, F, advect=True):
/home/runner/work/L96_demo/L96_demo/notebooks/L96_model.py:37: NumbaDeprecationWarning: The 'nopython' keyword argument was not supplied to the 'numba.jit' decorator. The implicit default value for this argument is currently False, but it will be changed to True in Numba 0.59.0. See https://numba.readthedocs.io/en/stable/reference/deprecation.html#deprecation-of-object-mode-fall-back-behaviour-when-using-jit for details.
  def L96_2t_xdot_ydot(X, Y, F, h, b, c):

Possible fix

Add parameter nopython=False in jit decorator

Will be addressed in the next 7 days

IamShubhamGupto commented 1 year ago

Adding (nopython=False) raised a new warning. Should shift to njit for a fix

reference - https://github.com/dsgibbons/shap/pull/68

IamShubhamGupto commented 1 year ago

Issue resolved and verified after #124 was merged

Screenshot 2023-06-20 at 11 36 52 AM

closing the issue