search

m2lines / L96_demo

Lorenz 1996 two time-scale model for learning machine learning
https://m2lines.github.io/L96_demo
Other
36 stars 20 forks source link

Fix climatology figure #122

Closed NoraLoose closed 1 year ago

NoraLoose commented 1 year ago

I believe there is a small bug in the gcm-parameterization-problem.ipynb notebook. The figure that shows the climatologies of X_true vs. X_gcm vs. X_gcm_no_param plots the wrong line for X_true, namely

plt.plot(dist[-1], linewidth=3, color="k", label="Truth")

This PR changes the line to

plt.plot(np.mean(X_true, 0), linewidth=3, color="k", label="Truth")

I think I installed pre-commit only after making my commits, so I hope things are not too messy. I can roll back my commits, and re-commit if necessary.

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

NoraLoose commented 1 year ago

Ok nice, pre-commit ci fixed it for us.