search

m2lines / L96_demo

Lorenz 1996 two time-scale model for learning machine learning
https://m2lines.github.io/L96_demo
Other
36 stars 20 forks source link

Reworked some of the neural network notebooks #128

Closed dhruvbalwada closed 1 year ago

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

IamShubhamGupto commented 1 year ago

@dhruvbalwada I will get back on this pr in a couple of hours

IamShubhamGupto commented 1 year ago

@dhruvbalwada Jupyter book is currently setup to compile all notebooks within the notebooks folder. Since the old_notebooks is a sub folder, they compile too.

To address this issue, I updated the config file to ignore that subfolder in this PR - https://github.com/m2lines/L96_demo/pull/129

Once merged with this branch, we should be good to merge with the main branch as well

dhruvbalwada commented 1 year ago

Thanks Shubham. I merged your PR, will this PR break things if it was now merged (since it does not have your changes?)

IamShubhamGupto commented 1 year ago

Thanks Shubham. I merged your PR, will this PR break things if it was now merged (since it does not have your changes?)

The PR was merged directly to this branch so we should be good to merge now

NoraLoose commented 1 year ago

Sorry for the late response! I see that the PR is merged already, so I guess a review is not required anymore?

dhruvbalwada commented 1 year ago

The way we have been doing this is to usually merge most of the changes to PR quickly, since it is quite hard to see all the changes in code version for the notebook. So (only if you have free time) it might still be good if you can look at the rendered notebooks and see if something seems off.