search

m2lines / L96_demo

Lorenz 1996 two time-scale model for learning machine learning
https://m2lines.github.io/L96_demo
Other
36 stars 20 forks source link

Creating initial release #155

Closed dhruvbalwada closed 4 months ago

dhruvbalwada commented 4 months ago

@IamShubhamGupto do you know how to solve the first remark that the reviewer made here about creating an initial release?

dhruvbalwada commented 4 months ago

In this process can we also delete the branches that have been merged (except the ones we are actively using to address reviewer comments), so that there is a fresh start.

IamShubhamGupto commented 4 months ago

Hey @dhruvbalwada, Ive merged the previous PR as I think it address the concerns of the review. For creating a release, Ive started a draft release here. I hope youre able to see it. If not, let me know if you have any preference for the release title and description. Ive provided very basic entries for now.

You can either edit the draft or share the contents with me and I'll publish the release.

dhruvbalwada commented 4 months ago

I think the title and description seem good to me. Do we need to do anything else before we publish? Now that the README has also been ingested, maybe it makes sense to publish? If we make some changes to read me in response to the reviews, will they automatically appear in the release?

IamShubhamGupto commented 4 months ago

I think the title and description seem good to me. Do we need to do anything else before we publish? Now that the README has also been ingested, maybe it makes sense to publish? If we make some changes to read me in response to the reviews, will they automatically appear in the release?

unfortunately, we would have to manually re release a newer version say v1.1 to incorporate further changes by the reviewers. Ill create a release now and if further changes are required, we can always bump up the version number

dhruvbalwada commented 4 months ago

Sounds good to me. Thank you.