Disable pre-commit CI - Githubissues

m2lines / convection-parameterization-in-CAM

Deployment of the convection parameterization scheme (previously from within SAM) deployed into the CAM model

MIT License

3 stars 2 forks source link

Disable pre-commit CI #31

Closed jdenholm closed 1 year ago

jdenholm commented 1 year ago

There is a pre-commit action which does nothing, but still fails, and can only be turned off by an admin. Can we get this turned off?

jdenholm commented 1 year ago

@LaureZanna is there an admin in the M2Lines organisation that could turn this off for us, please?

LaureZanna commented 1 year ago

@jdenholm : tell me what to do , and I will.

jatkinson1000 commented 1 year ago

It's something that's on all of the M2LiNES repositories, so I assume a setting at the organisation level rather than individual repo. Since we're not admins we can't see the settings, but Alaistair or Ryan might be able to help. It may be possible to apply a .yaml file specifically to this repo, but I'm not familiar with this particular bot.

LaureZanna commented 1 year ago

@rabernat @jbusecke @dhruvbalwada : do you have any experience with this ?

jbusecke commented 1 year ago

Yup. pre-commit usually runs code linters and can autofix issues, making reviews much easier and the code cleaner.

I suspect however that for this repo it does not work by default, since it is a private repo!

We have several possibilities here:

deactivate the integration with the pre-commit github app for this repo and implement the linters in the CI (e.g. #30) - note that pre-commit.ci is much faster than anything in gh actions (in case that matters).
make the repo public (but I assume its private for a reason?)

Either way I do not (yet) have admin rights on this repo/org, so I cannot do that yet.

jdenholm commented 1 year ago

Hi @jbusecke, thanks for this very helpful reply! Once we get our ducks in a row, we will probably only run the github-workflow-based CI on PRs, which is, as you say slower than pre-commit hooks, but it's something we can live with.

Can someone in M2Lines give you admin rights so that you can disable the pre-commit stuff? I'm not sure who has the the privileges.

LaureZanna commented 1 year ago

I have added @jbusecke to this repo with admin privilege. also note that this repo was created by @dorchard and is the admin on it so you can deal with pre-commit disabling on this repo too.

dorchard commented 1 year ago

Unfortunately this seems to be something configured at the organisation level, rather than the repo level. It should be under 'Settings' -> 'GitHub Apps' and then 'pre-commit ci'. @jbusecke let us know if it's not clear what to do though and we could do a call.

jdenholm commented 1 year ago

@jbusecke, any chance you could turn the pre-commit CI off now that Laure has kindly made you an admin, please?

jbusecke commented 1 year ago

Should be removed now.