m2lines / convection-parameterization-in-CAM

Deployment of the convection parameterization scheme (previously from within SAM) deployed into the CAM model
MIT License
3 stars 2 forks source link

Add standalone test-rig for CAM interface to examine code in more depth #70

Closed jatkinson1000 closed 2 months ago

jatkinson1000 commented 2 months ago

This Pull request introduces a standalone test rig that can be run to probe the internal workings of the YOG convection code in deeper detail.

It can be built and run from profile_test/ with instructions in the readme to generate a netcdf file that can then be plotted using the included python script.

The intermediate outputs to this file are controlled in the main code using a preprocessing directive (-DCAM_PROFILE).

It is a formalisation of testing and debugging routines that have been very useful in the development of the scheme, and should continue to be.

One comment would be that we perhaps need more explanation of exactly what we are doing and why in the readme, and perhaps an explanation of where the input data is from.

This addresses part of #65

jatkinson1000 commented 2 months ago

@MarionBWeinzierl I think in this case there is reasonable justification for sub-READMEs in some places, but with very clear signposting from the main one.

I think the YOG_convection README could be moved up as this is the 'main' code.