search

m2lines / data-gallery

https://m2lines.github.io/data-gallery/
Apache License 2.0
0 stars 2 forks source link

Add website preview as part of the CI? #4

Closed jbusecke closed 7 months ago

jbusecke commented 9 months ago

Hey everyone, I think it would be great to be able to preview changes as they would appear on the final website as part of the CI. This would be in addition to the review via review NB. The former will enable us to see if things are nicely converted to html the latter will let us focus on the content of the notebooks.

Having both would be awesome.

I have implemented something similar in out LEAP-Pangeo Technical Documentation which you might be able to use as a template. I am happy to help/discuss this further.

I think in terms of priority this is a medium for me, as it it not crucial to move ahead, but I think it will be very useful to avoid issues with the website (I have added labels to group by priority).

adcroft commented 7 months ago

A web preview would be very helpful and avoid broken pages. If this is not a heavy lift to implement then I think this should be done earlier rather later to help smooth PR evaluation.

IamShubhamGupto commented 7 months ago

@adcroft im working on this feature for the week, it'll be out soon

IamShubhamGupto commented 7 months ago

@jbusecke I can't seem to get GitHub actions to leave a comment, maybe you can help me fix that, im adding you as a developer now