m2lines / gz21_ocean_momentum

Stochastic-Deep Learning Parameterization of Ocean Momentum Forcing
MIT License
5 stars 1 forks source link

remove duplicate code in notebooks, `analysis/` #111

Open raehik opened 9 months ago

raehik commented 9 months ago

The Jupyter notebooks were updated to run correctly in previous commits, but they often used functions in the analysis/ folder which weren't used in the main library, and these weren't inspected. So we have two slightly different ways of e.g. obtaining CM2.6 ocean velocity data.

Also, a GlobalPlotter class defined in analysis/ is duplicated in some of the notebooks, with some changes (e.g. to keys used for the input dataset). At a glance these should be mergeable into a single instance.

review-notebook-app[bot] commented 9 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB