m2lines / gz21_ocean_momentum

Stochastic-Deep Learning Parameterization of Ocean Momentum Forcing
MIT License
5 stars 0 forks source link

Regression code in `regression/functions.py` are broken and unused #58

Closed raehik closed 1 year ago

raehik commented 1 year ago

The functions in regression/functions.py reference an unscoped global (commented out at the top since initial commit -- relevant blame line). They don't appear to be used anywhere. We could move the global to a parameter easily enough, but is this perhaps dead code?

raehik commented 1 year ago

@arthurBarthe - are these handy for manual testing, inspecting data & results?

arthurBarthe commented 1 year ago

I think those were written by another postdoc of Laure, for a different project. We can get rid of that file.