m2lines / gz21_ocean_momentum

Stochastic-Deep Learning Parameterization of Ocean Momentum Forcing
MIT License
5 stars 0 forks source link

Resolve dangling references to (local) scripts #62

Closed dorchard closed 1 year ago

dorchard commented 1 year ago

The previous README.md (which is being moved by PR https://github.com/m2lines/gz21_ocean_momentum/pull/60, to docs/slurm.md) references local scripts (e.g., modify $cmd in /home/ag7531/jobs/job-forcingdata.sh https://github.com/m2lines/gz21_ocean_momentum/blob/51481ee704ed983f0ae5c911029d7f450cd89e12/README.md?plain=1#L109 and https://github.com/m2lines/gz21_ocean_momentum/blob/51481ee704ed983f0ae5c911029d7f450cd89e12/README.md?plain=1#L132-L134) which will need generalising to relative paths. The referred to script also is not even present in the repository. Is it needed? If so @arthurBarthe please could you add it?

mondus commented 1 year ago

Happy to remove these references for now. The job scrips were required to hide some complexity around using containerisation (singularity). More extensive job script examples can be added later if needed.