search

m2lines / gz21_ocean_momentum

Stochastic-Deep Learning Parameterization of Ocean Momentum Forcing
MIT License
5 stars 1 forks source link

`cmip26.py` script name is mistaken (CM2.6, not CMIP) #87

Closed jbusecke closed 9 months ago

jbusecke commented 1 year ago

Quick very minor nitpick comment. The cmip26.py naming seems confusing to me. As I understand (and please correct me if I am wrong) the data used here is the CM2.6 GFDL simulation which is, despite the very similar name, not related to the Coupled Model Intercomparison Project (CMIP). Since CMIP is a very recognizable name in the climate community I would suggest to rename this module to avoid confusion.

raehik commented 1 year ago

Thanks @jbusecke . I'm 99% sure you're correct, I've been stating that the data we train on is from CM2.6. Not sure where cmip26 came from, or if cmip comes up much else in the project (I don't believe so).

The data step refactor should fix this. In the meantime, @arthurBarthe would you have any clarifications?

arthurBarthe commented 1 year ago

That is correct, the name cmip26 comes from some initial confusion of mine which I never corrected. Maybe cm26_data_step.py?

raehik commented 12 months ago

Will discuss in next dev meeting tomorrow.

raehik commented 12 months ago

Will be closed by #85 .

dorchard commented 10 months ago

85 is merged but we still need to do this (see e.g., https://github.com/m2lines/gz21_ocean_momentum/blob/main/src/gz21_ocean_momentum/cmip26.py).

raehik commented 10 months ago

handled in #97